Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

replace xhr,@cypress/request with fetch,node-fetch #461

Closed
wants to merge 1 commit into from
Closed

replace xhr,@cypress/request with fetch,node-fetch #461

wants to merge 1 commit into from

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 18, 2023 •
edited
Loading

use native fetch where available, node-fetch when not (Node.js < 18)

@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
node-fetch 2.7.0 None +0 162 kB node-fetch-bot

🚮 Removed packages: @cypress/[email protected]

@legobeat
replace xhr,@cypress/request with fetch,node-fetch
8ba3da9 
use native fetch when available, node-fetch for Node.js < 18
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Oct 18, 2023
@legobeat legobeat marked this pull request as ready for review October 18, 2023 04:31
@legobeat legobeat requested a review from a team as a code owner October 18, 2023 04:31
mcmire
mcmire reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I'd be fine with this, but I'm just curious whether we really need this to make a final release. I'm concerned there might be slight differences between the current implementation and fetch we aren't accounting for and considering there isn't great test coverage for this package it might not be necessary at this stage. What do you think?

@legobeat
Copy link
Contributor Author

legobeat commented Oct 20, 2023 •
edited
Loading

@mcmire good call, let's at least hold off on merging it for now. Could also consider keeping xhr for browser (I don;t have numbers but I imagine more common use-case?) and only do the replacement @cypress/request

@legobeat
Copy link
Contributor Author

Putting back on ice for now.

@legobeat legobeat closed this Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcmire mcmire mcmire left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @mcmire